Skip to content

Bump synapse version #13046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Bump synapse version #13046

merged 1 commit into from
Apr 4, 2025

Conversation

Oshanath
Copy link
Contributor

Related issue: wso2/api-manager#3772

Currently when invoking SSE APIs an error log is written Throttle object cannot be null.

In Synapse, parts of the request context is passed to the response once we configure it in passthrough-http.properties, including the above throttle_dto. But after reading this file, the list of properties allowed to be passed from the request to the response was dropped. A fix was sent to wso2-synapse that will successfully pass the defined properties from the request to the response.

This fix will make APIM use the fixed version of wso2-synapse.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes involve updating the pom.xml file for two projects. The first update modifies the version of the synapse dependency from 4.0.0-wso2v218 to 4.0.0-wso2v221. The second update adds a new dependency for the commons-validator library in the org.wso2.carbon.apimgt.gateway project. Additionally, in the DataProcessAndPublishingAgent.java file, regex patterns for validating IP addresses are replaced with the InetAddressValidator from the commons-validator library, simplifying the validation logic.

Changes

File Change Summary
pom.xml Updated <synapse.version> from 4.0.0-wso2v218 to 4.0.0-wso2v221.
components/apimgt/org.wso2.carbon.apimgt.gateway/pom.xml Added new dependency for commons-validator library.
components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/throttling/publisher/DataProcessAndPublishingAgent.java Removed regex patterns for IP validation; replaced with InetAddressValidator. Updated import statements accordingly.

Suggested reviewers

  • tgtshanika
  • chamilaadhi
  • tharindu1st
  • dushaniw
  • Arshardh
  • AnuGayan

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db9fd23 and 1360e2d.

📒 Files selected for processing (2)
  • components/apimgt/org.wso2.carbon.apimgt.gateway/pom.xml (1 hunks)
  • components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/throttling/publisher/DataProcessAndPublishingAgent.java (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build-product (3, group3)
  • GitHub Check: run-benchmark-test
  • GitHub Check: build-carbon
  • GitHub Check: build-product (4, group4)
  • GitHub Check: build-product (1, group1)
  • GitHub Check: build-product (2, group2)
🔇 Additional comments (3)
components/apimgt/org.wso2.carbon.apimgt.gateway/pom.xml (1)

336-339: Good addition of commons-validator dependency.

Adding the Apache Commons Validator library is a good decision for supporting the IP address validation improvements in DataProcessAndPublishingAgent.java. This follows best practices by leveraging a well-maintained library for validation tasks instead of custom implementations.

components/apimgt/org.wso2.carbon.apimgt.gateway/src/main/java/org/wso2/carbon/apimgt/gateway/throttling/publisher/DataProcessAndPublishingAgent.java (2)

9-9: Good import of InetAddressValidator.

Importing the InetAddressValidator from Apache Commons Validator library ensures proper IP address validation without relying on manual regex patterns.

236-247: Improved IP validation using InetAddressValidator.

Replacing custom regex patterns with the specialized InetAddressValidator is a solid improvement that:

  1. Eliminates potential regex bugs or edge cases
  2. Improves code maintainability
  3. Leverages a well-tested, standard implementation
  4. Makes the validation logic more readable

The implementation correctly handles both IPv4 and IPv6 addresses while maintaining the same functionality.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@npamudika npamudika merged commit ae2be55 into wso2:master Apr 4, 2025
8 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuGayan AnuGayan AnuGayan approved these changes

@tharindu1st tharindu1st Awaiting requested review from tharindu1st tharindu1st is a code owner

@chamilaadhi chamilaadhi Awaiting requested review from chamilaadhi chamilaadhi is a code owner

@Arshardh Arshardh Awaiting requested review from Arshardh Arshardh is a code owner

@dushaniw dushaniw Awaiting requested review from dushaniw dushaniw is a code owner

@tgtshanika tgtshanika Awaiting requested review from tgtshanika tgtshanika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oshanath @AnuGayan @npamudika